Add reasoning node type (LLM) and remove deprecated common actions#406
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 543e8702f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| action_schemas=action_schemas, | ||
| ) | ||
| out_params_schema = cleaned_params.get("expected_output_format") | ||
| ref_error = _validate_existing_references( |
There was a problem hiding this comment.
Parse reasoning output schemas supplied as strings
Reasoning params explicitly allow expected_output_format to be a string (see _reasoning_params_schema), but here the value is copied directly into out_params_schema without parsing. _schema_from_out_params_schema only accepts mappings, so a JSON schema provided as a string (e.g., from LLM tool calls) yields no schema and downstream bindings like {{ result_of.reasoning.foo }} will fail validation with “field does not exist.” This is a regression compared to the earlier common.ask_ai handling that parsed JSON strings; consider parsing string JSON or only setting out_params_schema when it’s already a mapping.
Useful? React with 👍 / 👎.
Motivation
Description
common.ask_ai.v1,common.classify_text.v1,common.join_list.v1,common.list_files.v1,common.split_list.v1,common.summarize.v1) from the business action registry and removed the outdated example assets underexamples/search_news_summarize.reasoningnode type and model (ReasoningNode) and extendedNode.model_validateto accept/validatereasoningnodes and their optionalout_params_schema._reasoning_params_schemaand integration into param completion (planner/params_tools.py), new planner toolsadd_reasoning_nodeandupdate_reasoning_node, and mirroredparams.expected_output_formatintoout_params_schemaon updates and param completion (planner/structure.py,planner/workflow_builder.py).ask_ai, and records/serializes results into the node outputs; validation and binding checks now treat a reasoning node'sexpected_output_format(or mirroredout_params_schema) as its output schema (executor/dynamic_executor.py,verification/binding_checks.py,verification/node_rules.py).expected_formatresults intocommon.ask_ai.v1outputs during workflow validation, and added visualization color for thereasoningnode type (velvetflow/visualization.py).Testing
Codex Task